Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of mutable parameters with values of 0 in Highs interface #2763

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Better handling of mutable parameters with values of 0 in Highs interface #2763

merged 2 commits into from
Mar 10, 2023

Conversation

michaelbynum
Copy link
Contributor

Fixes #2656 .

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@michaelbynum michaelbynum mentioned this pull request Mar 8, 2023
Closed
@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (a47fa92) 86.96% compared to head (904d04e) 86.96%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2763   +/-   ##
=======================================
  Coverage   86.96%   86.96%           
=======================================
  Files         752      752           
  Lines       86600    86603    +3     
=======================================
+ Hits        75313    75317    +4     
+ Misses      11287    11286    -1
Flag Coverage Δ
linux 83.95% <100.00%> (+<0.01%) ⬆️
osx 73.37% <0.00%> (-0.01%) ⬇️
other 84.13% <100.00%> (+<0.01%) ⬆️
win 81.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/contrib/appsi/solvers/highs.py 92.04% <100.00%> (+0.04%) ⬆️
pyomo/solvers/plugins/solvers/ASL.py 91.42% <0.00%> (-1.43%) ⬇️
pyomo/contrib/appsi/solvers/gurobi.py 84.57% <0.00%> (+0.11%) ⬆️
pyomo/core/expr/visitor.py 93.40% <0.00%> (+0.15%) ⬆️
pyomo/core/base/component.py 91.10% <0.00%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsiirola jsiirola merged commit ad2ba13 into Pyomo:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsiirola jsiirola jsiirola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior between the CBC and HiGHS
2 participants
@michaelbynum @jsiirola